Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: [pre-commit.ci] pre-commit autoupdate #2038

Merged
merged 3 commits into from
Oct 4, 2022
Merged

chore: [pre-commit.ci] pre-commit autoupdate #2038

merged 3 commits into from
Oct 4, 2022

Conversation

pre-commit-ci[bot]
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Oct 3, 2022 •
edited by matthewfeickert
Loading

updates:

* Update pre-commit hooks:
   - github.com/asottile/pyupgrade: v2.37.3 → v2.38.2
   - github.com/nbQA-dev/nbQA: 1.4.0 → 1.5.2

@pre-commit-ci
chore: [pre-commit.ci] pre-commit autoupdate
85ccb9e 
updates:
- [github.com/asottile/pyupgrade: v2.37.3 → v2.38.2](asottile/pyupgrade@v2.37.3...v2.38.2)
- [github.com/pre-commit/mirrors-mypy: v0.971 → v0.981](pre-commit/mirrors-mypy@v0.971...v0.981)
- [github.com/nbQA-dev/nbQA: 1.4.0 → 1.5.2](nbQA-dev/nbQA@1.4.0...1.5.2)
@codecov
Copy link

codecov bot commented Oct 3, 2022 •
edited
Loading

Codecov Report

Base: 98.30% // Head: 98.30% // No change to project coverage 👍

Coverage data is based on head (ea5d90d) compared to base (c80f6be).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2038   +/-   ##
=======================================
  Coverage   98.30%   98.30%           
=======================================
  Files          69       69           
  Lines        4530     4530           
  Branches      738      645   -93     
=======================================
  Hits         4453     4453           
  Misses         45       45           
  Partials       32       32
Flag Coverage Δ
contrib 27.52% <ø> (ø)
doctest 61.14% <ø> (ø)
unittests-3.10 96.31% <ø> (ø)
unittests-3.7 96.28% <ø> (ø)
unittests-3.8 96.33% <ø> (ø)
unittests-3.9 96.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@matthewfeickert matthewfeickert self-assigned this Oct 3, 2022
@matthewfeickert matthewfeickert added the chore Other changes that don't modify src or test files label Oct 3, 2022
@matthewfeickert
Copy link
Member 

 -   repo: https://github.com/pre-commit/mirrors-mypy
-    rev: v0.971
+    rev: v0.981

is causing errors of the form

mypy with Python 3.10....................................................Failed
- hook id: mypy
- exit code: 2

Deferral trace:
    jsonpatch:98
...
...
...
/home/feickert/.cache/pre-commit/repou_tp6v3h/py_env-python3.10/lib/python3.10/site-packages/jsonpatch-stubs/__init__.pyi: error: INTERNAL ERROR: maximum semantic analysis iteration count reached
/home/feickert/.cache/pre-commit/repou_tp6v3h/py_env-python3.10/lib/python3.10/site-packages/jsonpatch-stubs/__init__.pyi:229: error: INTERNAL ERROR -- Please try using mypy master on GitHub:
https://mypy.readthedocs.io/en/stable/common_issues.html#using-a-development-mypy-build
If this issue continues with mypy master, please report a bug at https://github.com/python/mypy/issues
version: 0.981
/home/feickert/.cache/pre-commit/repou_tp6v3h/py_env-python3.10/lib/python3.10/site-packages/jsonpatch-stubs/__init__.pyi:229: : note: please use --show-traceback to print a traceback when reporting a bug

I'm attaching the output of

pre-commit run mypy --all-files &> mypy-v0.981-error.txt

here: mypy-v0.981-error.txt

@matthewfeickert matthewfeickert mentioned this pull request Oct 3, 2022
Closed
@matthewfeickert
Copy link
Member

I'm going to revert the mypy bump and then we can manually fix that later once Issue #2039 is fixed.

@matthewfeickert
Copy link
Member

I'm going to merge this in as the mypy issue will get fixed in the next update, as noted in #2039 (comment).

@matthewfeickert matthewfeickert merged commit 5cc2252 into main Oct 4, 2022
@matthewfeickert matthewfeickert deleted the pre-commit-ci-update-config branch October 4, 2022 20:04
@matthewfeickert matthewfeickert mentioned this pull request Mar 31, 2023
Merged
4 tasks
matthewfeickert added a commit that referenced this pull request Mar 31, 2023
@matthewfeickert
chore(backport): Update pre-commit hooks (#2150)
74fcde9 
* Backport components of:
   - PR #2038
   - PR #2057
   - PR #2074
   - PR #2088
   - PR #2090
   - PR #2108
   - PR #2130
* Apply updated pre-commit hooks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewfeickert matthewfeickert matthewfeickert approved these changes

@kratsg kratsg Awaiting requested review from kratsg

@lukasheinrich lukasheinrich Awaiting requested review from lukasheinrich

Assignees

@matthewfeickert matthewfeickert

Labels
chore Other changes that don't modify src or test files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@matthewfeickert